Skip to content

fix: validate endpoint url #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

fix: validate endpoint url #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/llama_stack_client/lib/cli/configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import yaml
from prompt_toolkit import prompt
from prompt_toolkit.validation import Validator
from urllib.parse import urlparse

from llama_stack_client.lib.cli.constants import LLAMA_STACK_CLIENT_CONFIG_DIR, get_config_file_path

Expand All @@ -36,8 +37,8 @@ def configure(endpoint: str | None, api_key: str | None):
final_endpoint = prompt(
"> Enter the endpoint of the Llama Stack distribution server: ",
validator=Validator.from_callable(
lambda x: len(x) > 0,
error_message="Endpoint cannot be empty, please enter a valid endpoint",
lambda x: len(x) > 0 and (parsed := urlparse(x)).scheme and parsed.netloc,
error_message="Endpoint cannot be empty and must be a valid URL, please enter a valid endpoint",
),
)

Expand Down