Skip to content

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Mar 12, 2025

What does this PR do?

  • sync & delete unused files

Test Plan

  • integration test
pytest -v -s --nbval-lax ./docs/getting_started.ipynb

LLAMA_STACK_CONFIG=fireworks pytest -v tests/integration/ --text-model meta-llama/Llama-3.3-70B-Instruct
image

Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow good cleanup

wow wow unbelievable how we had this till now hehe

@ehhuang
Copy link
Contributor

ehhuang commented Mar 13, 2025

wow good cleanup

wow wow unbelievable how we had this till now hehe

yay 5 definitions of Document no mmore

yanxi0830 added a commit to llamastack/llama-stack that referenced this pull request Mar 13, 2025
# What does this PR do?
- Clean up dead SDK code in
llamastack/llama-stack-client-python#198
- Regen for local cache key issue

[//]: # (If resolving an issue, uncomment and update the line below)
[//]: # (Closes #[issue-number])

## Test Plan
```
pytest -v -s --nbval-lax ./docs/getting_started.ipynb

LLAMA_STACK_CONFIG=fireworks pytest -v tests/integration/ --text-model meta-llama/Llama-3.3-70B-Instruct
```

- CI:
https://github.com/meta-llama/llama-stack-ops/actions/runs/13823512113
<img width="1658" alt="image"
src="https://github.com/user-attachments/assets/1a2de383-35a2-47a0-8d80-d666d4970c34"
/>


[//]: # (## Documentation)
@yanxi0830 yanxi0830 merged commit 3116310 into main Mar 13, 2025
2 checks passed
@yanxi0830 yanxi0830 deleted the v017 branch March 13, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants