fix(release): push TypeScript tag in RC builds #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes: 1. Push branch before tag: RC workflow was only pushing tags, not the commits. The tag pointed to a local commit that didn't exist on remote. Now we push the branch first to ensure the lockfile commit exists, then push the tag. Final release workflow was already correct. 2. Remove pre-commit retry: Pre-commit exits non-zero when it modifies files (by design). The retry loop treated this as failure and retried unnecessarily. First run modifies lockfiles (exits 1), second run succeeds (exits 0). Fixed by removing retry and using '|| true' to ignore exit code. We check git status after to see if files changed.
The upload-packages-and-tag script was skipping TypeScript in the lockfile update loop (since it doesn't need lockfile updates), but the tag push was happening inside that loop. This meant the TypeScript tag was created but never pushed to the remote. Split the logic so TypeScript tags are pushed immediately after creation, before the lockfile update loop runs for Python repos.
The auto-bump section creates a venv for bumping main branch versions but wasn't installing pre-commit in it. When add_bump_version_commit tries to run lockfile updates, it fails with 'command not found'.
After a release, we should only create an auto-bump PR for the main stack repo, not for client libraries. Client library versions are managed separately.
Add explicit check for pre-commit before running it. The '|| true' is needed because pre-commit exits with code 1 when it modifies files (expected behavior), but we should fail loudly if pre-commit is not installed at all rather than silently continuing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the TypeScript client tag was created but never pushed during RC builds, causing the final release workflow to fail with "Tag vX.Y.ZrcN does not exist for stack-client-typescript".
Root Cause
In
upload-packages-and-tag/main.sh:continue(line 131)Fix
Split the logic so TypeScript tags are pushed immediately after creation, before the lockfile update loop runs for Python repos.
Test Plan
v0.3.1rc5tag for TypeScript client