Skip to content

Conversation

@leseb
Copy link
Collaborator

@leseb leseb commented Feb 19, 2025

What does this PR do?

Refine the existing update-readthedocs.yml workflow to enhance
automation and reliability. Updates include:

  • Expanding path triggers to cover all documentation files (docs/**) and
    build artifacts.
  • Adding steps to set up Python (3.11), install uv, sync dependencies,
    and build HTML using make html.
  • Ensuring the ReadTheDocs build trigger only runs on
    workflow_dispatch events.

These improvements help validate website builds in PRs, preventing
issues before merging.

Signed-off-by: Sébastien Han seb@redhat.com

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 19, 2025
@leseb leseb force-pushed the ci-for-build-site branch 5 times, most recently from 00c73bc to 2dfe175 Compare February 19, 2025 14:22
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion to combine workflows

@leseb leseb force-pushed the ci-for-build-site branch from 2dfe175 to 5ac1ad0 Compare February 20, 2025 09:17
@leseb leseb requested a review from ashwinb February 20, 2025 09:18
@leseb leseb changed the title ci: add GitHub Actions workflow to build the website ci: improve GitHub Actions workflow for website builds Feb 20, 2025
Refine the existing update-readthedocs.yml workflow to enhance
automation and reliability. Updates include:

- Expanding path triggers to cover all documentation files (docs/**) and
  build artifacts.
- Adding steps to set up Python (3.11), install uv, sync dependencies,
   and build HTML using make html.
- Ensuring the ReadTheDocs build trigger only runs on
   workflow_dispatch events.

These improvements help validate website builds in PRs, preventing
issues before merging.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb force-pushed the ci-for-build-site branch from 5ac1ad0 to 25fb1d9 Compare February 20, 2025 17:23
@leseb leseb requested a review from ashwinb February 20, 2025 17:23
@ashwinb ashwinb merged commit 33a64eb into llamastack:main Feb 21, 2025
4 checks passed
@leseb leseb deleted the ci-for-build-site branch February 21, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants