Skip to content

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Mar 7, 2025

Summary:
support added in llamastack/llama-stack-client-python#187

Test Plan:

LLAMA_STACK_CONFIG=fireworks pytest -s -v tests/integration/agents/test_agents.py --safety-shield meta-llama/Llama-Guard-3-8B --text-model meta-llama/Llama-3.1-8B-Instruct

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 7, 2025
@ehhuang ehhuang marked this pull request as ready for review March 7, 2025 18:47
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it error out pleasantly when it detects that the docstring isn't up to spec in some fashion?

@ashwinb
Copy link
Contributor

ashwinb commented Mar 7, 2025

This is super great and essential btw

@ehhuang
Copy link
Contributor Author

ehhuang commented Mar 7, 2025

Does it error out pleasantly when it detects that the docstring isn't up to spec in some fashion?

yea there's at least some amount of it in @client_tool
image

@ehhuang ehhuang merged commit fbd47bb into main Mar 7, 2025
9 checks passed
@ehhuang ehhuang deleted the pr1479 branch March 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants