Skip to content

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Mar 11, 2025

Summary:

  1. adds option to not use bwrap for code execution
  2. disable bwrap when running tests on macs

Test Plan:

LLAMA_STACK_CONFIG=fireworks pytest -s -v tests/integration/agents/test_agents.py --safety-shield meta-llama/Llama-Guard-3-8B --text-model meta-llama/Llama-3.1-8B-Instruct

Verify code_interpreter result in logs

INFO 2025-03-11 08:10:39,858 llama_stack.providers.inline.agents.meta_reference.agent_instance:1032 agents: tool
call code_interpreter completed with result: content='completed\n\n541\n' error_message=None error_code=None
metadata=None

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 11, 2025
@ehhuang ehhuang changed the title code exec test: code exec on mac Mar 11, 2025
@ehhuang ehhuang marked this pull request as ready for review March 11, 2025 15:27
@ashwinb
Copy link
Contributor

ashwinb commented Mar 11, 2025

what's the motivation? so we can actually get this code path exercised and robust?

@yanxi0830
Copy link
Contributor

Wouldn't this be a security risk?

@ehhuang
Copy link
Contributor Author

ehhuang commented Mar 11, 2025

what's the motivation? so we can actually get this code path exercised and robust?

Yea so we can actually run tests with code_interpreter on macs.

Wouldn't this be a security risk?

This is only enabled in pytest. Should be ok?

@ehhuang ehhuang force-pushed the pr1549 branch 3 times, most recently from be0fd4b to e7dcfa4 Compare March 12, 2025 23:18
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Summary:

Test Plan:
@ehhuang ehhuang merged commit 6bfcb65 into main Mar 13, 2025
13 checks passed
@ehhuang ehhuang deleted the pr1549 branch March 13, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants