Skip to content

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Mar 18, 2025

What does this PR do?

with the new /v1/providers API, /v1/inspect/providers is duplicative, deprecate it by removing the route, and add a test for the full /v1/providers API

resolves #1623

Test Plan

uv run pytest -v tests/integration/providers --stack-config=ollama --text-model="meta-llama/Llama-3.2-3B-Instruct" --embedding-model=all-MiniLM-L6-v2

Screenshot 2025-03-18 at 9 18 38 AM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 18, 2025
@ashwinb
Copy link
Contributor

ashwinb commented Mar 18, 2025

I think llama-stack-apps (at least) has a few places where we do client.providers.list() -- should we update those callsites first?

@cdoern
Copy link
Contributor Author

cdoern commented Mar 18, 2025

@ashwinb client.providers.list should still work I think! the v1/providers endpoint replaced v1/inspect/providers and v1/providers/provider_id is "inspect a singular provider with a config". So think leaving providers.list should be fine

@ashwinb
Copy link
Contributor

ashwinb commented Mar 18, 2025

client.providers.list should still work I think

could you verify this once?

@cdoern
Copy link
Contributor Author

cdoern commented Mar 20, 2025

@ashwinb:

Screenshot 2025-03-19 at 8 05 22 PM Screenshot 2025-03-19 at 8 05 56 PM

test_list tests client.providers.list

with the new /v1/providers API, /v1/inspect/providers is duplicative, deprecate it by removing the route, and add a test for the full /v1/providers API

Signed-off-by: Charlie Doern <cdoern@redhat.com>
@cdoern
Copy link
Contributor Author

cdoern commented Mar 20, 2025

just rebased as well to be safe!

@ashwinb ashwinb merged commit a483a58 into llamastack:main Mar 20, 2025
14 checks passed
franciscojavierarceo pushed a commit to franciscojavierarceo/llama-stack that referenced this pull request Mar 22, 2025
# What does this PR do?

with the new /v1/providers API, /v1/inspect/providers is duplicative,
deprecate it by removing the route, and add a test for the full
/v1/providers API

resolves llamastack#1623 

## Test Plan

`uv run pytest -v tests/integration/providers --stack-config=ollama
--text-model="meta-llama/Llama-3.2-3B-Instruct"
--embedding-model=all-MiniLM-L6-v2`

<img width="1512" alt="Screenshot 2025-03-18 at 9 18 38 AM"
src="https://github.com/user-attachments/assets/2db30f25-3ff6-4374-b39d-0047f093fe36"
/>

Signed-off-by: Charlie Doern <cdoern@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate /v1/inspect/providers

3 participants