feat: implement provider updating #1905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
leseb,
raghotham,
sixianyi0721,
terrytangyuan,
vladimirivic and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request has been automatically marked as stale because it has not had activity within 60 days. It will be automatically closed if no further activity occurs within 30 days. |
|
@cdoern , do you know if there has been any news about when/if the maintainers would accept something like this? It seems very useful. |
cdoern
force-pushed
the
provider-update
branch
2 times, most recently
from
6f843ea to
371755b
Compare
add `v1/providers/` which uses PUT to allow users to change their provider configuration this is a follow up to llamastack#1429 and related to llamastack#1359 a user can call something like: `llama_stack_client.providers.update(api="inference", provider_id="ollama", provider_type="remote::ollama", config={'url': 'http:/localhost:12345'})` or `llama-stack-client providers update inference ollama remote::ollama "{'url': 'http://localhost:12345'}"` this API works by adding a `RequestMiddleware` to the server which checks requests, and if the user is using PUT /v1/providers, the routes are re-registered with the re-initialized provider configurations/methods for the client, `self.impls` is updated to hold the proper methods+configurations this depends on a client PR, the CI will fail until then but succeeded locally Signed-off-by: Charlie Doern <cdoern@redhat.com>
being able to update providers means that admins should have the ability to turn this feature off. introduce `immutable` as a field in the Provider class. Defauling to false means all providers can be updated by default, but an admin at runtime can choose to set this to True to disable provider updating Signed-off-by: Charlie Doern <cdoern@redhat.com>
|
This is rather stale. But also -- why do we want users to be able to update provider configuration? I can imagine an admin wanting to do it I guess but we don't have well developed admin flows right now. |
|
stale; feel free to reopen if still applicable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add
v1/providers/which uses PUT to allow users to change their provider configurationthis is a follow up to #1429 and related to #1359
a user can call something like:
llama_stack_client.providers.update(api="inference", provider_id="ollama", provider_type="remote::ollama", config={'url': 'http:/localhost:12345'})or
llama-stack-client providers update inference ollama remote::ollama "{'url': 'http://localhost:12345'}"this API works by adding a
RequestMiddlewareto the server which checks requests, and if the user is using PUT /v1/providers, the routes are re-registered with the re-initialized provider configurations/methodsfor the client,
self.implsis updated to hold the proper methods+configurationsthis depends on a client PR, the CI will fail until then but succeeded locally
Test Plan
pytest -s -v tests/integration/providers/test_providers.py --stack-config=ollama --text-model=meta-llama/Llama-3.2-3B-Instructllama-stack-client providers update inference ollama remote::ollama "{'url': 'http://localhost:12345'}"