fix: add todo for schema validation #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
leseb,
raghotham,
sixianyi0721,
terrytangyuan,
vladimirivic and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
KPostOffice
force-pushed
the
todo_for_schema_validation
branch
from
87e1f95 to
f68ca6b
Compare
Signed-off-by: Kevin <kpostlet@redhat.com>
KPostOffice
force-pushed
the
todo_for_schema_validation
branch
from
f68ca6b to
220da33
Compare
KPostOffice
changed the title
booxter
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
This is definitely better than just leaving this code broken... Ideally we'd run integration tests for training but I'm stuck on llama models not being available without authN with tokens, which is not possible / desirable in github CI: #1786
leseb
approved these changes
Apr 29, 2025
franciscojavierarceo
pushed a commit
to franciscojavierarceo/llama-stack
that referenced
this pull request
May 9, 2025
# What does this PR do? Change validation to TODO same as was done [here](https://github.com/meta-llama/llama-stack/blob/main/llama_stack/providers/inline/eval/meta_reference/eval.py#L87) until validation can be implemented Closes llamastack#1849 ## Test Plan Signed-off-by: Kevin <kpostlet@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change validation to TODO same as was done here until validation can be implemented
Closes #1849
Test Plan