Skip to content

test(telemetry): Telemetry Tests #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2025
Merged

test(telemetry): Telemetry Tests #3805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dafffe8
fix(telemetry): jsonify attributes for easy unmarshalling
iamemilio Oct 14, 2025
83a5c9e
feat(telemetry): first iteration of in memory Otel tests
iamemilio Oct 14, 2025
9198c4d
fix(tests): address comments on telemetry test pr and support metrics
iamemilio Oct 14, 2025
4f82002
fix(telemetry_tests): fixture injects in memory collectors before lla…
iamemilio Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion llama_stack/providers/inline/telemetry/meta_reference/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ def __init__(self, _config: TelemetryConfig, deps: dict[Api, Any]) -> None:
metrics.set_meter_provider(metric_provider)

self.meter = metrics.get_meter(__name__)

self._lock = _global_lock

async def initialize(self) -> None:
Expand Down
4 changes: 2 additions & 2 deletions llama_stack/providers/utils/telemetry/trace_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def create_span_context(self: Any, *args: Any, **kwargs: Any) -> tuple:
"__class__": class_name,
"__method__": method_name,
"__type__": span_type,
"__args__": str(combined_args),
"__args__": json.dumps(combined_args),
}

return class_name, method_name, span_attributes
Expand All @@ -82,8 +82,8 @@ async def async_gen_wrapper(self: Any, *args: Any, **kwargs: Any) -> AsyncGenera
class_name, method_name, span_attributes = create_span_context(self, *args, **kwargs)

with tracing.span(f"{class_name}.{method_name}", span_attributes) as span:
count = 0
try:
count = 0
async for item in method(self, *args, **kwargs):
yield item
count += 1
Expand Down
Loading
Loading