chore!: remove telemetry API usage #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
cdoern
changed the title
ehhuang
reviewed
Oct 15, 2025
ehhuang
requested changes
Oct 15, 2025
ehhuang
reviewed
Oct 15, 2025
cdoern
force-pushed
the
remove-telem
branch
2 times, most recently
from
e3ab49c to
9d244b4
Compare
ehhuang
reviewed
Oct 15, 2025
ehhuang
reviewed
Oct 15, 2025
llama_stack/core/resolver.py
Outdated
Comment on lines
247
to
248
| "opentelemetry-sdk", | ||
| "opentelemetry-exporter-otlp-proto-http", |
There was a problem hiding this comment.
we should add these deps to pyproject.toml?
There was a problem hiding this comment.
good idea! let me do that instead
There was a problem hiding this comment.
looks like they're already in SERVER_DEPENDENCIES. I think that is good enough since those are included in every build?
cdoern
force-pushed
the
remove-telem
branch
3 times, most recently
from
2ba8570 to
e9c7784
Compare
remove telemetry as a providable API from the codebase. This includes removing it from generated distributions but also the provider registry, the router, etc relates to llamastack#3806 Signed-off-by: Charlie Doern <cdoern@redhat.com>
ehhuang
reviewed
Oct 16, 2025
| service_name: "${env.OTEL_SERVICE_NAME:=\u200B}" | ||
| sinks: ${env.TELEMETRY_SINKS:=} | ||
| otel_exporter_otlp_endpoint: ${env.OTEL_EXPORTER_OTLP_ENDPOINT:=} | ||
| post_training: |
There was a problem hiding this comment.
we should add telemetry.enabled: true in these configs so the behavior remains unchanged.
ehhuang
approved these changes
Oct 16, 2025
ehhuang
added a commit
that referenced
this pull request
Oct 16, 2025
# What does this PR do? old telemetry config was removed in #3815 ## Test Plan ❯ OTEL_SERVICE_NAME=aloha OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 uv run llama stack run starter
ehhuang
added a commit
that referenced
this pull request
Oct 16, 2025
# What does this PR do? old telemetry config was removed in #3815 ## Test Plan ❯ OTEL_SERVICE_NAME=aloha OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 uv run llama stack run starter
ehhuang
added a commit
that referenced
this pull request
Oct 16, 2025
# What does this PR do? leftover from #3815 ## Test Plan CI --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/llamastack/llama-stack/pull/3828). * #3830 * __->__ #3828
ehhuang
added a commit
that referenced
this pull request
Oct 16, 2025
# What does this PR do? old telemetry config was removed in #3815 ## Test Plan ❯ OTEL_SERVICE_NAME=aloha OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 uv run llama stack run starter
ehhuang
added a commit
that referenced
this pull request
Oct 16, 2025
# What does this PR do? old telemetry config was removed in #3815 ## Test Plan ❯ OTEL_SERVICE_NAME=aloha OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4318 uv run llama stack run starter <img width="1888" height="605" alt="image" src="https://github.com/user-attachments/assets/dd5cc9f0-213a-4dc6-9385-f61a3a13b4c3" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove telemetry as a providable API from the codebase. This includes removing it from generated distributions but also the provider registry, the router, etc
since
setup_loggeris tied pretty strictly toApi.telemetrybeing in impls we still need an "instantiated provider" in our implementations. However it should not be auto-routed or provided. So in validate_and_prepare_providers (called from resolve_impls) I made it so that if run_config.telemetry.enabled, we set up the meta-reference "provider" internally to be used so that log_event will work when called.This is the neatest way I think we can remove telemetry from the provider configs but also not need to rip apart the whole "telemetry is a provider" logic just yet, but we can do it internally later without disrupting users.
so telemetry is removed from the registry such that if a user puts
telemetry:as an API in their build/run config it will err out, but can still be used by us internally as we go through this transition.relates to #3806