-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly more compact ui settings #2590
Conversation
Changed Radio to Dropdown.
Fooocus follows the philosophy of always showing available options, not hiding them behind a select or accordion. |
I personally can understand the original intention of fooocus, but based on the native fooocus model drop-down options, can it be understood that due to the uncertain number of models, the use of drop-downs is allowed to avoid excessive stacking of options. |
Will be reevaluated in a few weeks, background info see #2617 (comment) |
Thank you for the review! Please forgive me I am a novice programmer and I am having a hard time understanding code and using GitHub in general.
It may also be useful to add a line with information about the selected resolution. However, in my current implementation it is updated only when any resolution item is selected. At startup it is empty and shows nothing. I don't know how to fix this or if it is necessary.
|
@Alexdnk adjusted, please check |
@mashb1t 'Aspect Ratios' Accordion it's is great realisation. I test it, and is ok. |
use javascript code instead of python handling for updates for lllyasviel#2590
use javascript code instead of python handling for updates for #2590
* Slightly more compact ui settings Changed Radio to Dropdown. * feat: change preset from option to select, add accordion for resolution * feat: change title of aspect ratios accordion on load and update * refactor: reorder image number slider, code cleanup * fix: add missing scroll down for metadata tab * fix: adjust indent --------- Co-authored-by: Manuel Schmid <dev@mash1t.de> Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>
use javascript code instead of python handling for updates for lllyasviel#2590
Changed Radio to Dropdown. If there are a lot of presets, it's a ui problem with Radiobutton.
And i suggest hiding the resolution selection under Accordion.
And simplify the file type selection.