Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker.md to prevent #2836 on windows #2985

Closed
wants to merge 3 commits into from

Conversation

stefanseeger
Copy link

On windows git is converting the line ending LF per default to CRLF, which will break the docker compose see #2836
To enforce git clone with line ending lf I updated the docker.md

@stefanseeger stefanseeger requested a review from lllyasviel as a code owner May 23, 2024 12:54
@mashb1t mashb1t changed the base branch from main to develop May 24, 2024 06:29
@mashb1t mashb1t self-requested a review as a code owner May 24, 2024 06:29
docker.md Outdated Show resolved Hide resolved
@stefanseeger
Copy link
Author

Hi @mashb1t ,
I just found that it might be a better solution to add a .gitattributes file enforcing the line endings for everyone using this repo.
See docs: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings
What do you think about it?

@mashb1t
Copy link
Collaborator

mashb1t commented May 24, 2024

@stefanseeger yes, sounds reasonable. Please go ahead and add the file, if not i can also do it.

@mashb1t
Copy link
Collaborator

mashb1t commented May 24, 2024

done in #2991

@mashb1t mashb1t closed this May 24, 2024
@mashb1t mashb1t added this to the 2.4.0 milestone May 24, 2024
@stefanseeger
Copy link
Author

@stefanseeger yes, sounds reasonable. Please go ahead and add the file, if not i can also do it.

You are too quick, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants