fix: adjust clip skip default value from 1 to 2 #3011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3003 (comment)
Background: Fooocus uses clip skip 2 by default, but the variable is called layer_idx and it works similar to ComfyUI, where skipped layers are counted down from -1 (no layer skipped) to infinity (set to last layer when loaded). Values > 12 are possible, they will somewhen reach a maximum of available layers, but are currently limited to 12 to prevent users from creating bad results.
The issues has been resolved by setting clip_skip to 2 by default instead of 1 and renaming the label to indicate the recommended default value.
Code references:
Fooocus/ldm_patched/modules/sdxl_clip.py
Line 9 in e8d88d3
Fooocus/ldm_patched/modules/sd2_clip.py
Line 9 in e8d88d3
Fooocus/ldm_patched/modules/sdxl_clip.py
Line 40 in e8d88d3
Fooocus/ldm_patched/modules/sd1_clip.py
Lines 106 to 111 in 1cc40d2