Code reorganization: moved configuration related code to common #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ira <IRAR@il.ibm.com>
mayabar
requested changes
Jul 31, 2025
pkg/common/config.go
Outdated
| // ParseCommandParamsAndLoadConfig loads configuration, parses command line parameters, merges the values | ||
| // (command line values overwrite the config file ones), and validates the configuration | ||
| func ParseCommandParamsAndLoadConfig() (*Configuration, error) { | ||
| config := NewConfig() |
Collaborator
There was a problem hiding this comment.
NewConfig could be a private function
Collaborator
Author
There was a problem hiding this comment.
Done. It was used in simulator test, but I changed the test.
Signed-off-by: Ira <IRAR@il.ibm.com>
mayabar
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108