Improvements to MPI histogram component #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix brushes; Fix the mpi rank on brushend
* 1st set of assorted improvements * First pass on improving the callsite information view * Initial docs
…pi-histogram-view
jarusified
force-pushed
the
fix-mpi-histogram-view
branch
from
72d43ec to
076f2ed
Compare
… fix-mpi-histogram-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Single mode's MPI histogram had a few bugs for the rendering the tooltip (often times it went behind the div), and the rank scale lines were not fully occupying the bin's width.
Unfortunately, this PR is kind of a mixed-up contribution. (Especially the last two contributions).
To resolve the above issue, this PR improves or fixes the following:
utils.pyfor improved measuring for the text inside a region or div.