Skip to content

Changes GitHub Action OS Image to Avoid Python Caching Issues#73

Merged
slabasan merged 4 commits intollnl:developfrom
TauferLab:python_gh_actions_fix
Dec 27, 2022
Merged

Changes GitHub Action OS Image to Avoid Python Caching Issues#73
slabasan merged 4 commits intollnl:developfrom
TauferLab:python_gh_actions_fix

Conversation

@ilumsden
Copy link
Collaborator

@ilumsden ilumsden commented Dec 6, 2022

This PR allows us to avoid this issue with the setup-python Action used in Hatchet's CI.

To do so, it simply changes the OS image for the CI from ubuntu-latest to ubuntu-20.04. When the linked issue is resolved, we can switch back to ubuntu-latest.

@ilumsden ilumsden added area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Dec 6, 2022
@ilumsden ilumsden requested a review from slabasan December 6, 2022 18:28
@ilumsden ilumsden self-assigned this Dec 6, 2022
@ilumsden
Copy link
Collaborator Author

ilumsden commented Dec 7, 2022

This PR will also upgrade the codecov Action used in the unit testing to v3. codecov-action v1 (which we were previously using) has been sunsetted and no longer works.

@ilumsden
Copy link
Collaborator Author

@slabasan this PR is now complete, pending a rebase. It now contains the following changes:

  • Fixes the original issue with the setup-python action described in the first comment of the PR
  • Changes .coveragerc so that all coverage files are saved into a .coverage/ subdirectory
  • Upgrades codecov-action from v1 (which no longer works) to v3
  • Adds several arguments to the invocation of codecov-action, namely:
    • verbose: enables verbose output from the action
    • env_vars: ensures the values of the runner's OS and PYTHON environment variables are included in the code coverage report
    • directory: ensures that the action looks in the correct place for the coverage files (i.e., the .coverage/ subdirectory)
  • Changes np.float to np.float64 in the timemory_json_data function in conftest.py because np.float has been removed from newer versions of NumPy

@ilumsden ilumsden force-pushed the python_gh_actions_fix branch from 762cf1f to dcbbc77 Compare December 20, 2022 03:10
@ilumsden ilumsden mentioned this pull request Dec 22, 2022
4 tasks
@slabasan slabasan merged commit dccd590 into llnl:develop Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-ci Issues and PRs related to continuous integration processes used by Hatchet developers priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants