-
Notifications
You must be signed in to change notification settings - Fork 15
Build libROM on Quartz #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
OK to test |
oseikuffuor1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tony. This looks good.
jeanlucf22
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is nice to share build scripts with everyone, and that is what we have been doing through the repo and scripts directory. But I would not change the CMakeLists.txt now: we don't have a use case. MGmol is not going to call libROM. We are going to build a driver that will use both libROM and MGmol as libraries.
I attempted to build libROM within MGmol as I thought we are going to build linear subspace projection based ROMs. In this case, the ROM part is intrusive and we need to call libROM within MGmol. This is similarly done in Laghos. |
Where do you have in mind to build that driver? If it resides in this repo, are you thinking of having a separate cmakelists.txt for the driver and linking librom only to that driver? |
|
@siuwuncheung @dreamer2368, I think @jeanlucf22 's idea is to build MGmol as a library so that we can have drivers that will link to both libROM and MGmol, calling the necessary functions to generate training data as needed. We would then expose more functionality to do the prediction part. I understand the benefit of having direct access to implement calls that might be intrusive, and we may very well do that at some point. But I think this approach is worth exploring since it will also demonstate how other DFT codes may benefit from the techniques we end up developing in libROM (in a less intrusive way). @dreamer2368, what you mention is along the lines of the approach we are thinking. Jean-Luc is working on an initial driver that we can use as a template for other drivers. |
|
@oseikuffuor1 |
* add libROM to CMakelists.txt * Add shell_script * Minor changes * Add module file
* add libROM to CMakelists.txt * Add shell_script * Minor changes * Add module file
To build mgmol with libROM on Quartz:
scripts/build_quartz_libROM.shto parent.csh build_quartz_libROM.sh