Snapshot collection/POD training for potential #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
changed the title
jeanlucf22
approved these changes
Jun 15, 2024
oseikuffuor1
approved these changes
Jun 17, 2024
Collaborator
oseikuffuor1
left a comment
oseikuffuor1
left a comment
There was a problem hiding this comment.
Looks good. Thanks Kevin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE PR #255 must be reviewed and merged first before this PR.
This PR adds a functionality to train POD basis for potential. For now, we take only total potential as snapshots, but we could add other potentials as well.