Update usage of Hamiltonian class #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlucf22
force-pushed
the
hamiltonian
branch
from
a5545a6 to
1193ba9
Compare
oseikuffuor1
reviewed
Nov 6, 2025
| #include "SquareSubMatrix2DistMatrix.h" | ||
|
|
||
| template <> | ||
| void MGmol<LocGridOrbitals>::addHlocal2matrix(LocGridOrbitals& orbitalsi, |
Collaborator
There was a problem hiding this comment.
Should this be moved to Hamiltonian class as well?
oseikuffuor1
approved these changes
Nov 6, 2025
Collaborator
oseikuffuor1
left a comment
oseikuffuor1
left a comment
There was a problem hiding this comment.
Thanks, looks good. I left a question/ comment about addlocal2matrix function for using variablesparsematrix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.