Expose more preconditioner parameters in interface #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oseikuffuor1
approved these changes
Dec 22, 2025
Collaborator
oseikuffuor1
left a comment
oseikuffuor1
left a comment
There was a problem hiding this comment.
I left one comment for your review, but otherwise, it looks good. Thanks.
|
|
||
| short ncycl = 2; | ||
| if (level == max_levels_) ncycl = 4; | ||
| short ncycl = npresmooth_; |
Collaborator
There was a problem hiding this comment.
Is this overloading the meaning of ncycl? i.e. number of vcycle sweeps and number of smoother sweeps? Maybe we should make ncycl an interface parameter as well?
Collaborator
Author
There was a problem hiding this comment.
It is just an intermediate variable to set the number of iterations in first (smoothing) loop. If coarsest level, will exit after that loop. Not changing behavior compared to previous version
jeanlucf22
added a commit
that referenced
this pull request
Jan 27, 2026
* Some optimization in GridFunc when equal to 0 (#399) * Expose more preconditioner parameters in interface (#401) * Fix job scripts --------- Co-authored-by: Jean-Luc Fattebert <fattebertj@ornl.gov> Co-authored-by: Seung Whan Chung <seung.chung@austin.utexas.edu> Co-authored-by: Daniel Osei-Kuffuor <oseikuffuor1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.