Skip to content

Conversation

@nickhrdy
Copy link
Contributor

@nickhrdy nickhrdy commented Jul 27, 2020

The test suite generates a list of tests for a set of topologies to ensure mpibind functions correctly. The details of the generated tests can be found in /test/README.md and the corresponding implementation is in tests/test_utils.c. Currently, 3 topologies are being used for testing. In addititon, there's a separate test to check for proper return codes and error handling.

This PR also adds with autotools support for building and testing purposes. Includes an autogen.sh script that can be run before ./configure.

Outstanding items are:

  • Make sure make install works as intended
  • Reviewing the list of tests
  • Create tests to ensure environment variables are being set correctly

Closes #3

@nickhrdy nickhrdy mentioned this pull request Jul 27, 2020
@nickhrdy nickhrdy changed the title WIP: Test Suite and Autotools Test Suite and Autotools Jul 28, 2020
@eleon
Copy link
Collaborator

eleon commented Jul 29, 2020

@nickhrdy , it seems we have two features in this PR:

  1. Autotools configuration
  2. Test suite

Can you split this PR into two PRs as outlined above?

@eleon
Copy link
Collaborator

eleon commented Aug 3, 2020

We decided to separate this PR into two: one for autotools support and the other for the test suite. The first one is done.

@eleon eleon closed this Aug 3, 2020
@nickhrdy nickhrdy mentioned this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing test suite

2 participants