-
Notifications
You must be signed in to change notification settings - Fork 34
Spack Enzyme build #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spack Enzyme build #1412
Conversation
8a9435f to
dbb41a5
Compare
…rdcode it off for now so all tests pass, add compile time check for enzyme
5671480 to
72eba14
Compare
tupek2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit outside my expertise, but looks amazing! Regarding mac builds... is it likely to break current builds, or are you saying that mac build + enzyme is still a future development?
I updated the instructions (clang 14 -> clang 19) but did not test them. |
|
OK, I've been using clang 19 on my mac for a few weeks now. I've had small issues with petsc, but maybe unrelated to that change. Thanks. |
chapman39
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty chris. let me know how you want to delegate future prs
|
It looks like this will turn off Tribol + Enzyme once it is merged, so exact Jacobians will no longer be available (if true). There will likely need to be some work on the Tribol side to work with ClangEnzyme instead of LLDEnzyme, so it may not be trivial to turn this back on. |
ebchin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me look into Tribol's exact Jacobians before we merge this...
ebchin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @white238, we will do a follow-on PR with updated Tribol soon.
Adds Enzyme as a TPL that is not fully enabled but exists in the TPL build. Set
-DSERAC_USE_ENZYME=ONon the command line forconfig-build.pyorcmaketo enable.Notable Changes:
Things currently out of scope of this PR but up for debate and will hopefully done shortly after:
Updated docs:
https://serac.readthedocs.io/en/task-white238-spack_enzyme_compiler/sphinx/quickstart.html#building-serac-s-dependencies-via-spack-uberenv
https://serac.readthedocs.io/en/task-white238-spack_enzyme_compiler/sphinx/dev_guide/tpl_build.html
PRs this is dependent on:
llnl/uberenv#147
llnl/radiuss-spack-configs#134
Worked around Spack issue:
spack/spack#51244