convert benchmarks to bluss' bencher #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's not how my crates behave, the find benches/example.rs and so on. |
|
Also, to lower expectations (I've already mentioned this on the repo's issues), bencher is just a port and I'm not setting out to make a better benchmark runner; I hope that need is filled by someone eventually. |
|
Perhaps a transient cargo-nightly bug (I just regained a stable network connection, will rustup & re-check). |
|
Might be some detail of how the Cargo.toml is written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one small hitch: it seems to search in SRC/ instead of benches/ cc @bluss
@Veedrac think we should merge this?