Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove packed_simd in favor of std::simd and #![feature(portable_simd)] #92

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Apr 9, 2024

Fixes #91

As mentioned in the packed_simd README, the crate is superseded by #![feature(portable_simd)].

I'm honestly not familiar with simd or the new std::simd support, but I think I managed to get things working without the use of packed_simd (at least from local testing).

Fixes 91

As mentioned in the `packed_simd` README, the crate is superseded by
`#![feature(portable_simd)]`.
@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 9, 2024

Based on this comment it also seems that packed_simd isn't being actively maintained, so that might be another reason to stop using it.

@llogiq
Copy link
Owner

llogiq commented Apr 11, 2024

For now, I think we have all the relevant platforms (but riscv, need to get my hands on one of those...), so this isn't that relevant anymore. Still it's good to go with the times, so thank you for your contribution!

@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 11, 2024

Happy to help 😁!

bytecount is one of rustfmt's dependencies so when I noticed the generic-simd feature wasn't working on nightly I wanted to try and get it resolved.

I also noticed that packed_simd is mentioned in the README, would you like me to update those docs as part of this PR too?

@llogiq
Copy link
Owner

llogiq commented Apr 13, 2024

That would be great.

This replaces the simd docs that used to reference packed_simd.
@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 16, 2024

@llogiq I've updated the docs. Let me know if there are any other changes you'd like to see

@llogiq
Copy link
Owner

llogiq commented Apr 17, 2024

No, that looks comprehensive. Thank you!

@llogiq llogiq merged commit 68ecb39 into llogiq:master Apr 17, 2024
15 checks passed
@ytmimi ytmimi deleted the fix-generic-simd branch April 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generic-simd feature fails to build on nightly
2 participants