Skip to content

Commit

Permalink
[CIR][NFC] Fix some consistency issues with missing features
Browse files Browse the repository at this point in the history
  • Loading branch information
bcardosolopes committed Oct 16, 2024
1 parent 0a0c556 commit 078965e
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

using AArch64ABIKind = ::cir::AArch64ABIKind;
using ABIArgInfo = ::cir::ABIArgInfo;
using MissingFeature = ::cir::MissingFeatures;
using MissingFeatures = ::cir::MissingFeatures;

namespace mlir {
namespace cir {
Expand Down Expand Up @@ -60,7 +60,7 @@ class AArch64TargetLoweringInfo : public TargetLoweringInfo {
public:
AArch64TargetLoweringInfo(LowerTypes &LT, AArch64ABIKind Kind)
: TargetLoweringInfo(std::make_unique<AArch64ABIInfo>(LT, Kind)) {
cir_cconv_assert(!MissingFeature::swift());
cir_cconv_assert(!MissingFeatures::swift());
}

unsigned getTargetAddrSpaceFromCIRAddrSpace(
Expand Down Expand Up @@ -97,7 +97,7 @@ ABIArgInfo AArch64ABIInfo::classifyReturnType(Type RetTy,
if (!isAggregateTypeForABI(RetTy)) {
// NOTE(cir): Skip enum handling.

if (MissingFeature::fixedSizeIntType())
if (MissingFeatures::fixedSizeIntType())
cir_cconv_unreachable("NYI");

return (isPromotableIntegerTypeForABI(RetTy) && isDarwinPCS()
Expand All @@ -114,13 +114,13 @@ AArch64ABIInfo::classifyArgumentType(Type Ty, bool IsVariadic,
Ty = useFirstFieldIfTransparentUnion(Ty);

// TODO(cir): check for illegal vector types.
if (MissingFeature::vectorType())
if (MissingFeatures::vectorType())
cir_cconv_unreachable("NYI");

if (!isAggregateTypeForABI(Ty)) {
// NOTE(cir): Enum is IntType in CIR. Skip enum handling here.

if (MissingFeature::fixedSizeIntType())
if (MissingFeatures::fixedSizeIntType())
cir_cconv_unreachable("NYI");

return (isPromotableIntegerTypeForABI(Ty) && isDarwinPCS()
Expand Down

0 comments on commit 078965e

Please sign in to comment.