Suggest building for the host arch

[AlexDenisov]

No description provided.

[lanza]

This is good in principle, but we haven't done the diligence to build all the target specific codegen classes you'd need for this to work. x86_64-unknown-linux-gnu was what we started out with.

[AlexDenisov]

Yeah, the limitations are understood. I'm running Apple Silicon and thought it would be a better default for non-x86 users.

[bcardosolopes]

@AlexDenisov thanks for fixing the docs, definitely makes sense. Probably better if we change to "X86;AArch64" so the tests can pass - did you end up running the tests?

[AlexDenisov]

Just gave it a try with X86;AArch64: CIR specific ones are passing (ninja check-clang-cir check-clang-cir-codegen),
but something is broken with check-all. I didn't dig deeper, but it seems CIR related:

error: 'error' diagnostics seen but not expected:
  (frontend): generated arguments do not match in round-trip
error: 'note' diagnostics seen but not expected:
  (frontend): generated arguments #1 in round-trip: "-cc1" "-verify" "-o" "-" "-fsyntax-only" "-x" "cir" "/opt/LLVM/clangir/clang/test/SemaHLSL/prohibit_pointer.hlsl" "-triple" "dxil-pc-shadermodel6.0-library" "-nostdsysteminc" "-isystem" "/opt/LLVM/clangir/llvm/cmake-build-debug/lib/clang/16.0.0/include" "-std=hlsl2021" "-ffp-contract=off" "-fno-experimental-relative-c++-abi-vtables" "-fno-file-reproducible" "-O0" "-fno-emulated-tls" "-fdiagnostics-hotness-threshold=0" "-fdiagnostics-misexpect-tolerance=0"
  (frontend): generated arguments #2 in round-trip: "-cc1" "-verify" "-o" "-" "-fsyntax-only" "-x" "cir" "/opt/LLVM/clangir/clang/test/SemaHLSL/prohibit_pointer.hlsl" "-triple" "dxil-pc-shadermodel6.0-library" "-nostdsysteminc" "-isystem" "/opt/LLVM/clangir/llvm/cmake-build-debug/lib/clang/16.0.0/include" "-O0" "-fno-emulated-tls" "-fdiagnostics-hotness-threshold=0" "-fdiagnostics-misexpect-tolerance=0"

The full list:

Failed Tests (56):
  Clang :: AST/HLSL/RWBuffer-AST.hlsl
  Clang :: AST/HLSL/ResourceStruct.hlsl
  Clang :: AST/HLSL/ast-dump-comment-cbuffe-tbufferr.hlsl
  Clang :: AST/HLSL/cbuffer_tbuffer.hlsl
  Clang :: AST/HLSL/pch.hlsl
  Clang :: AST/HLSL/pch_hlsl_buffer.hlsl
  Clang :: AST/HLSL/pch_with_buf.hlsl
  Clang :: AST/HLSL/resource_binding_attr.hlsl
  Clang :: AST/HLSL/vector-alias.hlsl
  Clang :: AST/HLSL/vector-constructors.hlsl
  Clang :: CodeGenHLSL/GlobalConstructorFunction.hlsl
  Clang :: CodeGenHLSL/GlobalConstructorLib.hlsl
  Clang :: CodeGenHLSL/GlobalConstructors.hlsl
  Clang :: CodeGenHLSL/GlobalDestructors.hlsl
  Clang :: CodeGenHLSL/basic_types.hlsl
  Clang :: CodeGenHLSL/buffer-array-operator.hlsl
  Clang :: CodeGenHLSL/builtins/RWBuffer-annotations.hlsl
  Clang :: CodeGenHLSL/builtins/RWBuffer-constructor.hlsl
  Clang :: CodeGenHLSL/builtins/RWBuffer-subscript.hlsl
  Clang :: CodeGenHLSL/builtins/abs.hlsl
  Clang :: CodeGenHLSL/builtins/create_handle.hlsl
  Clang :: CodeGenHLSL/builtins/sqrt.hlsl
  Clang :: CodeGenHLSL/disable_opt.hlsl
  Clang :: CodeGenHLSL/entry.hlsl
  Clang :: CodeGenHLSL/float3.hlsl
  Clang :: CodeGenHLSL/half.hlsl
  Clang :: CodeGenHLSL/semantics/GroupIndex-codegen.hlsl
  Clang :: CodeGenHLSL/shader_type_attr.hlsl
  Clang :: CodeGenHLSL/validator_version.hlsl
  Clang :: Driver/dxc_D.hlsl
  Clang :: Driver/hlsl_no_stdinc.hlsl
  Clang :: ParserHLSL/access_specifiers.hlsl
  Clang :: ParserHLSL/cb_error.hlsl
  Clang :: ParserHLSL/invalid_inside_cb.hlsl
  Clang :: ParserHLSL/semantic_parsing.hlsl
  Clang :: Preprocessor/predefined-macros-hlsl.hlsl
  Clang :: SemaHLSL/AvailabilityMarkup.hlsl
  Clang :: SemaHLSL/BuiltIns/RWBuffers.hlsl
  Clang :: SemaHLSL/BuiltIns/vector-constructors-erros.hlsl
  Clang :: SemaHLSL/BuiltIns/vector-errors.hlsl
  Clang :: SemaHLSL/GlobalConstructors.hlsl
  Clang :: SemaHLSL/Semantics/entry_parameter.hlsl
  Clang :: SemaHLSL/Semantics/missing_entry_annotation.hlsl
  Clang :: SemaHLSL/Wave.hlsl
  Clang :: SemaHLSL/WaveBuiltinAvailability.hlsl
  Clang :: SemaHLSL/cb_error.hlsl
  Clang :: SemaHLSL/entry.hlsl
  Clang :: SemaHLSL/num_threads.hlsl
  Clang :: SemaHLSL/prohibit_pointer.hlsl
  Clang :: SemaHLSL/prohibit_reference.hlsl
  Clang :: SemaHLSL/resource_binding_attr_error.hlsl
  Clang :: SemaHLSL/shader_type_attr.hlsl
  Clang-Unit :: Driver/./ClangDriverTests/11/13
  LLVM :: tools/llvm-objcopy/ELF/mirror-permissions-unix.test
  MLIR :: Dialect/Math/canonicalize.mlir
  MLIR :: mlir-tblgen/op-attribute.td


Testing Time: 3256.64s
  Skipped          :    69
  Unsupported      : 18986
  Passed           : 64130
  Expectedly Failed:    99
  Failed           :    56

[AlexDenisov]

Ok, I am on a slightly dated version, this fix does the trick 7da9b77 for HLSL failures, but I'm still seeing the Dialect/Math/canonicalize.mlir and mlir-tblgen/op-attribute.td.

Let me just give a try to the most recent version 😄

[bcardosolopes]

Hi @AlexDenisov

Let me just give a try to the most recent version 😄

I see the "-fsyntax-only" "-x" "cir" which is indeed suspicious. I'm gonna try this out later and see if I can repro. It's weird because we shouldn't be affecting anything outside clang/test/CIR, so very likely a bug!

[AlexDenisov]

In the end all the tests passed (with the exception of a couple of unrelated failures, see #16 #14).

[bcardosolopes]

@AlexDenisov does that mean we are safe to add this PR in? I haven't tested the ARM stuff myself, but if you did and everything passes I'm happy to add it to the build instructions.

[AlexDenisov]

Yeah, it seems to be working - at least all the tests pass @bcardosolopes