[CIR][ABI][AArch64] Support struct passing with coercion through memory #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
gitoleg
commented
Nov 12, 2024
clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerFunction.cpp
Outdated
Show resolved
Hide resolved
gitoleg
commented
Nov 12, 2024
| auto tmp = createTmpAlloca(CGF, Src.getLoc(), SrcTy); | ||
| CGF.getRewriter().create<StoreOp>(Src.getLoc(), Src, tmp); | ||
| auto len = createUInt64(CGF, Src.getLoc(), DstSize.getFixedValue()); | ||
| createMemCpy(CGF, tmp, Dst, len); |
There was a problem hiding this comment.
here are the changes for the title - we emit a temp alloca (basically that's why we need the changes in the CIRBaseBuilder - we don't have any hint here where to insert it. Thus, we insert it as LLVM does - in the function start
gitoleg
commented
Nov 12, 2024
gitoleg
commented
Nov 12, 2024
gitoleg
commented
Nov 13, 2024
bcardosolopes
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support for one more case of passing structs by value, with
memcpyemitted.First of all, don't worry - despite the PR seems big, it's basically consist of helpers + refactoring. Also, there is a minor change in the
CIRBaseBuilder- I made static thegetBestAllocaInsertPointmethod in order to call it from lowering - we discussed once - and I here we just need it (or copy-paste the code, which doesn't seem good).I will add several comments in order to simplify review.