[CIR][NFC] Add getBreakTarget method to cir::BreakOp
#1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommymcm
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
xlauko
reviewed
Aug 31, 2025
tommymcm
force-pushed
the
break-target
branch
from
69801b4 to
7eec012
Compare
andykaylor
reviewed
Sep 2, 2025
bcardosolopes
approved these changes
Sep 3, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM after pending comment
tommymcm
force-pushed
the
break-target
branch
from
7eec012 to
2633195
Compare
tommymcm
added a commit
to tommymcm/clangir
that referenced
this pull request
Sep 5, 2025
`cir::BreakOp::getBreakTarget` gets the innermost `cir::LoopOpInterface`
or `cir::SwitchOp` containing this `break`.
For example:
```
A: for (...) {
B: for(...) {
break; // target = B
C: switch (...) {
default: break; // target = C
}
break; // target = A
}
```
NOTE: This is a part of a broader effort I am working on to make
querying CIR control flow facts more easily. If folks have any design
notes or ideas, please share them.
---------
Co-authored-by: Tommy McMichen <tommymcmichen@fb.com>
bcardosolopes
pushed a commit
that referenced
this pull request
Sep 15, 2025
) After #1878, we introduced a dependency from the LoopOpInterface on BreakOp. While here add the BreakOp handling, which will be tests by a pass coming soon. Co-authored-by: Tommy McMichen <tommymcmichen@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cir::BreakOp::getBreakTargetgets the innermostcir::LoopOpInterfaceorcir::SwitchOpcontaining thisbreak.For example:
NOTE: This is a part of a broader effort I am working on to make querying CIR control flow facts more easily. If folks have any design notes or ideas, please share them.