[CIR] Add implementation and support skeleton for maybeEmitThunks #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badumbatish
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
badumbatish
changed the title
bcardosolopes
approved these changes
Sep 18, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Seems like all paths lead to an assert, and the rest is same as codegen, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1898
This PR adds to the implementation of
maybeEmitThunksinclang/lib/CIR/CodeGen/CIRGenVTables.cpp.Newly declared/defined functions are ported from OG.
Some missings are
Type::canLosslesslyBitCastToandsetDLLStorageClass.No tests are added since the implementation is not finished yet.