-
Notifications
You must be signed in to change notification settings - Fork 180
[CIR][CUDA] Register global variables #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcardosolopes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after minor nit
|
Good to land once the conflict is solved |
|
@AdUhTkJm are you ok with me fixing this and adding HIP support? @bcardosolopes are you ok with having a single PR about CUDA/HIP. Or do you want these to be separate? |
as long as you add tests I'm totally ok with it (it can even share the same file and just use different RUN lines) |
Yes of course. Thanks for your help! |
|
Pushed on a separate PR (#1980). Added tests for HIP and fixed a minor. |
|
@bcardosolopes OG has separate tests for HIP/CUDA. It will be really crowded in the LIT expressions. I will keep tests separate for now. |
|
Thanks folks, closing this one in favor of #1980 |
The process is essentially the same as registering global functions.
This currently only works for
__device__and__shared__variables. For textures and surfaces, another registration function will be needed. (We don't have support for these variables in CIR yet, and I have no idea what they really are.)