Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen] Refactor StructType builders #294

Merged
merged 3 commits into from
Nov 1, 2023
Merged

[CIR][CIRGen] Refactor StructType builders #294

merged 3 commits into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. [CIR][CIRGen] Refactor StructType builders 

    Instead of using a single builder for every possible StructType, we now
have three builders: identified complete, identified incomplete, and
anonymous struct types. This allows us to enforce correctness and to
explicitly show the intent when creating a StructType.

This patch also adds support for anonymous structs type aliases. When a
StructType has no name, it will generate a `ty_anon_<kind>` alias.
Conflicts are automatically resolved by MLIR.
    @sitio-couto
    sitio-couto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    476fa8c View commit details
    Browse the repository at this point in the history

  2. Support anon structs aliasing

    @sitio-couto
    sitio-couto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fb2026d View commit details
    Browse the repository at this point in the history

  3. Fix missing LIT directive in test

    @sitio-couto
    sitio-couto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f7387fa View commit details
    Browse the repository at this point in the history