Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen] Ensure unique names for template specializations #295

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[CIR][CIRGen] Ensure unique names for template specializations #295

merged 1 commit into from
Nov 1, 2023

Conversation

sitio-couto
Copy link
Collaborator

Currently, different specializations of a template will generate distinct types with the same name. To properly differentiate each specialization, this patch includes the template arguments in the name of the type.

This will be required to support mutable structs uniquely identified by their names.

@sitio-couto
[CIR][CIRGen] Ensure unique names for template specializations
97e874d 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the
name of the type.

This will be required to support mutable structs uniquely identified by
their names.
bcardosolopes
bcardosolopes approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit cc80061 into llvm:main Nov 1, 2023
@sitio-couto sitio-couto deleted the vinicius/fix-template-spec-names branch November 14, 2023 11:55
lanza pushed a commit that referenced this pull request Dec 20, 2023
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
d75e3c7 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
aa0018e 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
9500b3b 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
9385689 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
96a3e5a 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
591d938 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
343f5bb 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
bd012af 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
5402661 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
18b3392 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
3dfbbbc 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (llvm#295
927c581 
)

Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][CIRGen] Ensure unique names for template specializations (#295)
6b90bd9 
Currently, different specializations of a template will generate
distinct types with the same name. To properly differentiate each
specialization, this patch includes the template arguments in the name
of the type.

This will be required to support mutable structs uniquely identified by
their names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitio-couto @bcardosolopes