[CIR] Add validation tests for scalar casts #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a couple typos in the validation failure messages for scalar casts
bcardosolopes
approved these changes
Nov 15, 2023
|
|
||
| !u32i = !cir.int<u, 32> | ||
| cir.func @cast9(%p : !u32i) { | ||
| %2 = cir.cast(integral, %p : !u32i), f32 // expected-error {{requires !IntegerType for result}} |
There was a problem hiding this comment.
Looks like you also found a bug here, this should print !cir.int, I wonder if we are still using mlir::IntegerType instead of cir::IntType or if the error message is just not ideal. Let's track this on another issue.
lanza
pushed a commit
that referenced
this pull request
Dec 20, 2023
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Fix a couple typos in the validation failure messages for scalar casts
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Fix a couple typos in the validation failure messages for scalar casts
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Fix a couple typos in the validation failure messages for scalar casts
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Fix a couple typos in the validation failure messages for scalar casts
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
Fix a couple typos in the validation failure messages for scalar casts
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Fix a couple typos in the validation failure messages for scalar casts
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Fix a couple typos in the validation failure messages for scalar casts
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Fix a couple typos in the validation failure messages for scalar casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple typos in the validation failure messages for scalar casts