Skip to content

[CIR][IR] Implement cir.break operation #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

[CIR][IR] Implement cir.break operation #395

merged 2 commits into from
Jan 16, 2024

Conversation

sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jan 11, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Same rationale as cir.continue, it detaches the representation of the
C/C++ break statement into a separate operation. This simplifies
lowering and verifications related to break statements, as well as the
definition and lowering of the cir.yield operation.

@sitio-couto
[CIR][IR] Implement cir.break operation
a0ecd25 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

[ghstack-poisoned]
This was referenced Jan 11, 2024
Merged
Merged
Merged
bcardosolopes
bcardosolopes approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for "breaking" this into self contained PRs :D
LGTM

@sitio-couto
Update on "[CIR][IR] Implement cir.break operation"
a4d10c5 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

[ghstack-poisoned]
@sitio-couto sitio-couto merged commit a4d10c5 into gh/sitio-couto/3/base Jan 16, 2024
sitio-couto added a commit that referenced this pull request Jan 16, 2024
@sitio-couto
[CIR][IR] Implement cir.break operation
a10ad2d 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
@sitio-couto sitio-couto deleted the gh/sitio-couto/3/head branch January 16, 2024 20:53
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
a0efb4b 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
44e8d76 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
f29a834 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: llvm#395
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
759a192 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
fa28ed4 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
7009bb9 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: llvm#395
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
65880d7 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
854b81b 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96c3abe51d717c2fa6ca9e0073e42e770c6
Pull Request resolved: llvm/clangir#395
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
812735a 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: llvm#395
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
633176a 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: llvm#395
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
20629c6 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
lanza pushed a commit that referenced this pull request Mar 18, 2025
@sitio-couto @lanza
[CIR][IR] Implement cir.break operation
96cfd59 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96
Pull Request resolved: #395
xlauko pushed a commit to trailofbits/instafix-llvm that referenced this pull request Mar 28, 2025
@sitio-couto @xlauko
[CIR][IR] Implement cir.break operation
fd9c9aa 
Same rationale as `cir.continue`, it detaches the representation of the
C/C++ `break` statement into a separate operation. This simplifies
lowering and verifications related to `break` statements, as well as the
definition and lowering of the `cir.yield` operation.

ghstack-source-id: 929cf96c3abe51d717c2fa6ca9e0073e42e770c6
Pull Request resolved: llvm/clangir#395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitio-couto @bcardosolopes