[CIR][CIRGen] Support for initialization of unions. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Mar 15, 2024
| } A; | ||
|
|
||
| void foo(int x) { | ||
| A a = {.x = x}; |
There was a problem hiding this comment.
I'd prefer if we could raise this initialization a bit, it shouldn't block progress though. Create an issue to track it.
|
I had to mark the test invalid because of a conflicting change in
f27ace1
because I didn't wait for the tests to finish before I merged. Do you mind
fixing it up in some follow up PR?
Thank you!
…On Thu, Mar 14, 2024 at 8:24 PM Bruno Cardoso Lopes < ***@***.***> wrote:
Merged #495 <#495> into main.
—
Reply to this email directly, view it on GitHub
<#495 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWJDTCQKXVGHT7A7KMIMRTYYJSVFAVCNFSM6AAAAABEHCKTNSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGEZDMMRQGI4TSOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
|
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for initialization of unions. The change is copy-pasted from the original CodeGen.