Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Codegen] fix union init with constant #548

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[CIR][Codegen] fix union init with constant #548

merged 1 commit into from
Apr 17, 2024

Conversation

gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Apr 17, 2024 •
edited
Loading

Minor fix for the case when union fields have different sizes and union is inited with a constant.
Example:

typedef union {
  short a;
  int b;
} A;

bcardosolopes
bcardosolopes approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit b288e79 into llvm:main Apr 17, 2024
7 checks passed
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (#548)
247779a 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (#548)
d2a6011 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (#548)
080f276 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (llvm#548)
bceb2d0 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (llvm#548)
b4bd94b 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (llvm#548)
6e75939 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
lanza pushed a commit that referenced this pull request Nov 5, 2024
@gitoleg @lanza
[CIR][Codegen] Fix union init with constant (#548)
ed7225b 
Minor fix for the case when union fields have different sizes and union
is inited with a constant.
Example:
```
typedef union {
  short a;
  int b;
} A;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitoleg @bcardosolopes