Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold method #663

Merged
merged 6 commits into from
Jun 13, 2024
Merged

[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold method #663

merged 6 commits into from
Jun 13, 2024

Conversation

Kritoooo
Copy link
Contributor

@Kritoooo Kritoooo commented Jun 6, 2024

This pr is a part of #593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify tests.

bcardosolopes
bcardosolopes requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

clang/lib/CIR/Dialect/IR/CIRDialect.cpp Outdated Show resolved Hide resolved
clang/lib/CIR/Dialect/IR/CIRDialect.cpp Outdated Show resolved Hide resolved
clang/lib/CIR/Dialect/IR/CIRDialect.cpp Show resolved Hide resolved
bcardosolopes
bcardosolopes approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you. LGTM with one clarifying question / comment but almost there.

clang/test/CIR/Lowering/region-simplify.cir Show resolved Hide resolved
@bcardosolopes bcardosolopes merged commit 3b9f698 into llvm:main Jun 13, 2024
6 checks passed
@Kritoooo Kritoooo deleted the br_fold branch June 14, 2024 01:25
bcardosolopes added a commit that referenced this pull request Jul 8, 2024
@bcardosolopes
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
5792eb0 
…p::fold method (#663)"

This reverts commit 3b9f698.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@lanza
[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold …
4959834 
…method (llvm#663)

This pr is a part of llvm#593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify
tests.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@lanza
[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold …
b3e990a 
…method (llvm#663)

This pr is a part of llvm#593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify
tests.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@bcardosolopes @lanza
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
6611a0e 
…p::fold method (llvm#663)"

This reverts commit 3b9f698.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@smeenai
[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold …
edbb927 
…method (llvm#663)

This pr is a part of llvm#593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify
tests.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@bcardosolopes @smeenai
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
4f3512f 
…p::fold method (llvm#663)"

This reverts commit 3b9f698.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@bcardosolopes @smeenai
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
407d47b 
…p::fold method (llvm#663)"

This reverts commit 3b9f698.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@lanza
[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold …
569c21f 
…method (llvm#663)

This pr is a part of llvm#593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify
tests.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@bcardosolopes @lanza
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
6045328 
…p::fold method (llvm#663)"

This reverts commit 3b9f698.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@lanza
[CIR][Transforms] Move RemoveRedundantBranches logic into BrOp::fold …
e6ada21 
…method (#663)

This pr is a part of #593 .
Move RemoveRedundantBranches logic into BrOp::fold method and modify
tests.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@bcardosolopes @lanza
Revert "[CIR][Transforms] Move RemoveRedundantBranches logic into BrO…
de0bd14 
…p::fold method (#663)"

This reverts commit 3b9f698.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-mile seven-mile seven-mile left review comments

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kritoooo @bcardosolopes @seven-mile