Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRDataLayout]moving CIRDataLayout to MLIRCIR #693

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Jun 18, 2024

fix build failure
undefined reference to `cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in CIR Codegen

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 55e1496 into llvm:main Jun 18, 2024
7 checks passed
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
fix build failure 
undefined reference to
`cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in
CIR Codegen
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
fix build failure 
undefined reference to
`cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in
CIR Codegen
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
fix build failure 
undefined reference to
`cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in
CIR Codegen
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
fix build failure 
undefined reference to
`cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in
CIR Codegen
lanza pushed a commit that referenced this pull request Nov 5, 2024
fix build failure 
undefined reference to
`cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
by breaking circular dependency caused by the fact CIRDataLayout was in
CIR Codegen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants