[CIR][ABI] Add unsigned int CC lowering for x86_64 #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,6 +162,17 @@ class ABIArgInfo { | |||
| AI.setSignExt(false); | |||
| return AI; | |||
| } | |||
| static ABIArgInfo getZeroExtend(mlir::Type Ty, mlir::Type T = nullptr) { | |||
| // NOTE(cir): Enumerations are IntTypes in CIR. | |||
clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRLowerContext.cpp
Outdated
Show resolved
Hide resolved
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing types.
sitio-couto
force-pushed
the
vinicius/add-x86-zeroextend-cc-lowering
branch
from
92b5444 to
af736d1
Compare
sitio-couto
force-pushed
the
vinicius/add-x86-zeroextend-cc-lowering
branch
from
af736d1 to
84a0fe2
Compare
sitio-couto
commented
Jun 30, 2024
There was a problem hiding this comment.
@bcardosolopes applied.
How does this fits with the plan we discussed about incremental support already as part of the oficial pipeline? Can you please outline the plan?
I backtracked to the original plan: implement the basics CC lowering bits first, then flip the -fclangir-call-conv-lowering flag.
Moving this pass into the official pipeline in its current state requires too many logical changes just for the code to work, changes that would later have to be reverted.
| @@ -150,6 +162,17 @@ class ABIArgInfo { | |||
| AI.setSignExt(false); | |||
| return AI; | |||
| } | |||
| static ABIArgInfo getZeroExtend(mlir::Type Ty, mlir::Type T = nullptr) { | |||
| // NOTE(cir): Enumerations are IntTypes in CIR. | |||
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary bits to lower arguments and return values of type unsigned int for the x86_64 target. This includes adding logic for extend and direct argument-passing kinds.