Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][NFC] Fix bug in MLIR lowering of cir.call #728

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Jul 10, 2024

This PR fixes the bug described as in #727 (comment). It should resolve the crash reported in #727 .

This patch should resolve the crash reported in llvm#727 .
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for the quick fix @Lancern, LGTM

@bcardosolopes bcardosolopes merged commit 7c4d03a into llvm:main Jul 10, 2024
7 checks passed
@Lancern Lancern deleted the fix-call-op-mlir-lowering branch July 11, 2024 13:26
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This PR fixes the bug described as in
llvm#727 (comment). It
should resolve the crash reported in llvm#727 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR fixes the bug described as in
llvm#727 (comment). It
should resolve the crash reported in llvm#727 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR fixes the bug described as in
llvm#727 (comment). It
should resolve the crash reported in llvm#727 .
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This PR fixes the bug described as in
llvm#727 (comment). It
should resolve the crash reported in llvm#727 .
lanza pushed a commit that referenced this pull request Nov 5, 2024
This PR fixes the bug described as in
#727 (comment). It
should resolve the crash reported in #727 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants