[CIR][IR] Fix parsing of dsolocal in cir.func #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
changed the title
Lancern
requested changes
Jul 12, 2024
| @@ -1935,6 +1936,8 @@ ParseResult cir::FuncOp::parse(OpAsmParser &parser, OperationState &state) { | |||
| state.addAttribute(lambdaNameAttr, parser.getBuilder().getUnitAttr()); | |||
| if (parser.parseOptionalKeyword(noProtoNameAttr).succeeded()) | |||
| state.addAttribute(noProtoNameAttr, parser.getBuilder().getUnitAttr()); | |||
| if (parser.parseOptionalKeyword(dsolocalNameAttr).succeeded()) | |||
| state.addAttribute(dsolocalNameAttr, parser.getBuilder().getUnitAttr()); | |||
There was a problem hiding this comment.
According to FuncOp::print, I believe dsolocal should rather come after the visibility attribute? See in FuncOp::print:
clangir/clang/lib/CIR/Dialect/IR/CIRDialect.cpp
Lines 2129 to 2140 in 42a4292
There was a problem hiding this comment.
Thanks! good catch! fixed in the next commit
bcardosolopes
changed the title
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
as title. document will be in another PR as it seems to be a different upstream branch
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
as title. document will be in another PR as it seems to be a different upstream branch
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
as title. document will be in another PR as it seems to be a different upstream branch
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
as title. document will be in another PR as it seems to be a different upstream branch
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
as title. document will be in another PR as it seems to be a different upstream branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title. document will be in another PR as it seems to be a different upstream branch