Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unique ID to distinguish same name structure. #739

Closed
wants to merge 3 commits into from
Closed

Use unique ID to distinguish same name structure. #739

wants to merge 3 commits into from

Conversation

566hub
Copy link
Contributor

@566hub 566hub commented Jul 13, 2024 •
edited
Loading

  1. Use unique ID to distinguish same name structure.
  2. Realize RG and GET_RG op to realize global register variale.
  3. Achieve union's bitfields.

zouwangjun z30038331 added 2 commits July 13, 2024 15:17
@566hub
Realize RG and GET_RG op which are copied from cir.Global op. The con…
c008ae7 
…cept is that the same asm label means a unique abstract memory address with u64i type, and get_rg will return ptr<u64i>. We could use cir.cast(bitcast) to transform ptr<u64i> to ptr<other type>.
@566hub
Achieve union's bitfields additionally.
e436133
@Lancern
Copy link
Member

Lancern commented Jul 14, 2024 •
edited
Loading

Hi @566hub thanks for your work on this. But this PR contains several problems that could stop reviewers from reviewing it:

  • Could you focus on one point within a single PR? I don't see a clear connection between the 3 commits that constitute this PR. If they intend to implement separate functionalities, please separate them into different PRs.
  • This PR does not include any tests. Please add tests that clearly show what you intend to implement. You could refer to tests under clang/test/CIR/CIRGen for how to write CIRGen tests.

You may also find LLVM's new contributor guide helpful: https://llvm.org/docs/Contributing.html

@566hub
Copy link
Contributor Author

566hub commented Jul 15, 2024

Hi @566hub thanks for your work on this. But this PR contains several problems that could stop reviewers from reviewing it:

  • Could you focus on one point within a single PR? I don't see a clear connection between the 3 commits that constitute this PR. If they intend to implement separate functionalities, please separate them into different PRs.
  • This PR does not include any tests. Please add tests that clearly show what you intend to implement. You could refer to tests under clang/test/CIR/CIRGen for how to write CIRGen tests.

You may also find LLVM's new contributor guide helpful: https://llvm.org/docs/Contributing.html

Hi, @Lancern. It’s my first time to submit PR so I’m sorry that I made some mistakes. And I will resubmit PR today. Thank you for your advise.

@bcardosolopes bcardosolopes mentioned this pull request Jul 15, 2024
Open
@bcardosolopes
Copy link
Member

Closing this in favor of #740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@566hub @Lancern @bcardosolopes