Skip to content

Commit 3e790bd

Browse files
[not] Update disable-symbolization.test to work with internal shell
This test is a special case as it executes two commands that are special cased in the internal shell implementation. env runs entirely inside the internal shell whereas not is handled specially, but still executed externally. The internal shell does reorder execution of these though, putting env commands before not which means we do not pick up environment variables set by not. These complications make it easier to just ensure that we invoke the actual env binary (by calling it through bash) rather than using the internal shell implementation. Fixes #106627 by fixing the test, but without fixing the redirection issue given the complexity does not seem justified. Reviewers: ilovepi, MaskRay, petrhosek Reviewed By: MaskRay Pull Request: #157236
1 parent aa9af2a commit 3e790bd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# When building on Windows under cmd.exe and GnuWin32, 'env' fails if no
22
# arguments are provided.
33
# UNSUPPORTED: system-windows
4-
# RUN: not --crash env > %t || true
5-
# RUN: cmp -s %t /dev/null || FileCheck %s < %t
4+
# RUN: not --crash bash -c env > %t || true
5+
# RUN: FileCheck %s < %t
66

77
# CHECK-DAG: LLVM_DISABLE_CRASH_REPORT=1
88
# CHECK-DAG: LLVM_DISABLE_SYMBOLIZATION=1

0 commit comments

Comments
 (0)