[not] Update disable-symbolization.test to work with internal shell #157236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
MaskRay
approved these changes
Sep 6, 2025
|
Should we update the lit implementation handling for |
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
We theoretically can, but it's not that simple. The test runner already explicitly reorders them due to how llvm-project/llvm/utils/lit/lit/TestRunner.py Line 851 in d2646ca |
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Sep 9, 2025
This test is a special case as it executes two commands that are special cased in the internal shell implementation. env runs entirely inside the internal shell whereas not is handled specially, but still executed externally. The internal shell does reorder execution of these though, putting env commands before not which means we do not pick up environment variables set by not. These complications make it easier to just ensure that we invoke the actual env binary (by calling it through bash) rather than using the internal shell implementation. Fixes llvm#106627 by fixing the test, but without fixing the redirection issue given the complexity does not seem justified. Pull Request: llvm#157236
boomanaiden154
changed the base branch from
users/boomanaiden154/main.not-update-disable-symbolizationtest-to-work-with-internal-shell
to
main
boomanaiden154
deleted the
users/boomanaiden154/not-update-disable-symbolizationtest-to-work-with-internal-shell
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 9, 2025
…nal shell This test is a special case as it executes two commands that are special cased in the internal shell implementation. env runs entirely inside the internal shell whereas not is handled specially, but still executed externally. The internal shell does reorder execution of these though, putting env commands before not which means we do not pick up environment variables set by not. These complications make it easier to just ensure that we invoke the actual env binary (by calling it through bash) rather than using the internal shell implementation. Fixes #106627 by fixing the test, but without fixing the redirection issue given the complexity does not seem justified. Reviewers: ilovepi, MaskRay, petrhosek Reviewed By: MaskRay Pull Request: llvm/llvm-project#157236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is a special case as it executes two commands that are special
cased in the internal shell implementation. env runs entirely inside the
internal shell whereas not is handled specially, but still executed
externally. The internal shell does reorder execution of these though,
putting env commands before not which means we do not pick up
environment variables set by not.
These complications make it easier to just ensure that we invoke the
actual env binary (by calling it through bash) rather than using the
internal shell implementation.
Fixes #106627 by fixing the test, but without fixing the redirection
issue given the complexity does not seem justified.