Skip to content

Commit

Permalink
[runtimes] Don't use -Wall on clang-cl builds
Browse files Browse the repository at this point in the history
`-Wall` on clang-cl is equivalent to `-Weverything` on clang. We already add the correct warning flag depending whether we are in an MSVC-like environment, so just remove it from the list of flags that get passed unconditionally.

Spies: libcxx-commits

Differential Revision: https://reviews.llvm.org/D146378
  • Loading branch information
philnik777 committed Mar 19, 2023
1 parent 4601bcd commit e6cc0fa
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion runtimes/cmake/Modules/WarningFlags.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ function(cxx_add_warning_flags target enable_werror enable_pedantic)
endif()
# TODO: Should -Wconversion be enabled?
target_add_compile_flags_if_supported(${target} PRIVATE
-Wall
-Wextra
-Wnewline-eof
-Wshadow
Expand Down

0 comments on commit e6cc0fa

Please sign in to comment.