-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL] bitcasts emitted instead of vector conversions in binary operators #106253
Closed
Labels
Comments
25 tasks
llvm-beanz
added a commit
to llvm-beanz/llvm-project
that referenced
this issue
Sep 13, 2024
HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating `vector<T,1>` to `T` early to allow other transformations. Fixes llvm#106253
EugeneZelenko
added
the
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
label
Sep 26, 2024
@llvm/issue-subscribers-clang-frontend Author: Chris B (llvm-beanz)
Clang currently is resolving different cast expressions for binary operator arguments than for function argument expressions. This causes bitcasts to be used instead of correct implicit conversion sequences.
See reproduction case: https://hlsl.godbolt.org/z/jKGcGbE4Y This change will require the following:
|
llvm-beanz
added a commit
to llvm-beanz/llvm-project
that referenced
this issue
Sep 27, 2024
types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating vector<T,1> to T early to allow other transformations. Fixes llvm#106253 ../clang/test/SemaHLSL/Language/UsualArithmeticConversions.hlsl
llvm-beanz
added a commit
that referenced
this issue
Sep 27, 2024
HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating vector<T,1> to T early to allow other transformations. Fixes #106253 Re-lands #108659
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this issue
Sep 27, 2024
HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating `vector<T,1>` to `T` early to allow other transformations. Fixes llvm#106253
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this issue
Oct 4, 2024
HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating `vector<T,1>` to `T` early to allow other transformations. Fixes llvm#106253
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this issue
Oct 4, 2024
HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: microsoft/hlsl-specs#311 There is one case that may need additional handling for implicitly truncating vector<T,1> to T early to allow other transformations. Fixes llvm#106253 Re-lands llvm#108659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Clang currently is resolving different cast expressions for binary operator arguments than for function argument expressions. This causes bitcasts to be used instead of correct implicit conversion sequences.
See reproduction case: https://hlsl.godbolt.org/z/jKGcGbE4Y
This change will require the following:
The text was updated successfully, but these errors were encountered: