Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DirectX] Replace resource accesses in the device address space to typedbuffer load and store #114848

Closed
bogner opened this issue Nov 4, 2024 · 0 comments · Fixed by #116726
Closed

[DirectX] Replace resource accesses in the device address space to typedbuffer load and store #114848

bogner opened this issue Nov 4, 2024 · 0 comments · Fixed by #116726
Assignees
@bogner
Labels
backend:DirectX

Comments

@bogner
Copy link
Contributor

bogner commented Nov 4, 2024

The frontend will generate accesses into resources via a llvm.dx.resource.access intrinsic that indexes into a resource handle and provides a pointer in the HLSL device address space. We need to have a pass that transforms these accesses post-inlining to dxil store and load intrinsics.

This issue tracks creating this pass and implementing handling for replacing these accesses with llvm.dx.typedbuffer.load and llvm.dx.typedbuffer.store. Handling for more complicated access patterns (ie llvm.dx.rawbuffer.*) will be tracked separately.
@bogner bogner moved this to Planning in HLSL Support Nov 4, 2024
@bogner bogner self-assigned this Nov 4, 2024
@damyanp damyanp moved this from Planning to Active in HLSL Support Nov 4, 2024
@damyanp damyanp moved this from Active to Needs Review in HLSL Support Nov 18, 2024
bogner added a commit to bogner/llvm-project that referenced this issue Nov 19, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
d4e8605 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
@bogner bogner mentioned this issue Nov 19, 2024
Merged
bogner added a commit to bogner/llvm-project that referenced this issue Nov 20, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
f276438 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Nov 25, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
0af8bca 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Nov 26, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
46a5841 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Nov 28, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
32e03e7 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 3, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
424b003 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 12, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
b726105 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 12, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
d2e380d 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 12, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
e595ba7 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 12, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
54de636 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 16, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
59a9432 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit to bogner/llvm-project that referenced this issue Dec 18, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass
981de56 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes llvm#114848.
bogner added a commit that referenced this issue Dec 18, 2024
@bogner
[DirectX] Introduce the DXILResourceAccess pass (#116726)
0fca76d 
This pass transforms resource access via `llvm.dx.resource.getpointer`
into buffer loads and stores.

Fixes #114848.
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogner bogner

Labels
backend:DirectX
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DirectX] Introduce the DXILResourceAccess pass bogner/llvm-project
1 participant
@bogner