Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clang] Add single quotes around __builtin_bit_cast in diagnostic messages #116118

Closed
a-tarasyuk opened this issue Nov 13, 2024 · 0 comments · Fixed by #116120
Closed

[Clang] Add single quotes around __builtin_bit_cast in diagnostic messages #116118

a-tarasyuk opened this issue Nov 13, 2024 · 0 comments · Fixed by #116120
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer

Comments

@a-tarasyuk
Copy link
Member

#115940 (comment)

should fix the other diagnostics to also put single quotes around __builtin_bit_cast -- we generally put single quotes around syntactic constructs in diagnostic messages
@github-actions github-actions bot added the clang Clang issues not falling into any other category label Nov 13, 2024
@a-tarasyuk a-tarasyuk mentioned this issue Nov 13, 2024
Merged
@EugeneZelenko EugeneZelenko added clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer and removed clang Clang issues not falling into any other category labels Nov 14, 2024
Sirraide pushed a commit that referenced this issue Nov 19, 2024
@a-tarasyuk
[Clang] [NFC] Add single quotes around __builtin_bit_cast (#116120)
6aa80f0 
Fixes #116118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:diagnostics New/improved warning or error message in Clang, but not in clang-tidy or static analyzer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Clang] add single quotes around __builtin_bit_cast a-tarasyuk/llvm-project
2 participants
@a-tarasyuk @EugeneZelenko