compiler printf format warning doesn't really need to happen

[d3x0r]

Compiled as C++...

   uintptr psvNew = 0;
   printf( "Socket is not a server socket %p", psvNew );

 warning: format ‘%p’ expects argument of type ‘void*’, but argument 2 has type ‘uintptr_t {aka long unsigned int}’ [-Wformat=]
   printf( "Socket is not a server socket %p", psvNew );

This should never actually be an issue. [u]intptr is defined as a integer type large enough to hold a pointer. It should always take the same amount of space as a pointer, and a pointer can round-trip to and from the type without issue.

[AaronBallman]

It's formally undefined behavior to pass an [u]inptr_t to a varargs function which then reads out a pointer because those are not compatible types. Also, it's possible for the pointer output and the integer output to result in different values (nothing says the conversion between the two types needs to keep the same value; just that it needs to be able to round-trip back). I don't think we support any platforms that do those kind of shenanigans though. But at the very least, -Wformat-pedantic should continue to diagnose this code.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Jim B (d3x0r)

Compiled as C++...

   uintptr psvNew = 0;
   printf( "Socket is not a server socket %p", psvNew );

 warning: format ‘%p’ expects argument of type ‘void*’, but argument 2 has type ‘uintptr_t {aka long unsigned int}’ [-Wformat=]
   printf( "Socket is not a server socket %p", psvNew );

This should never actually be an issue. [u]intptr is defined as a integer type large enough to hold a pointer. It should always take the same amount of space as a pointer, and a pointer can round-trip to and from the type without issue.